From d91a4e3decc163c953f89e9277299f86ef24712a Mon Sep 17 00:00:00 2001 From: zyoshoka <107108195+zyoshoka@users.noreply.github.com> Date: Sun, 27 Apr 2025 10:49:23 +0900 Subject: [PATCH] fix(ci): change Chromatic build to be triggered when frontend `package.json` is edited instead of lockfile (#15793) * fix(ci): correct invalid condition for skipping Chromatic build * fix: change to be triggered when frontend `package.json` is edited instead of lockfile * chore: disable automatic rebase of frontend Renovate PRs --- .github/workflows/storybook.yml | 6 +----- packages/frontend/.storybook/changes.ts | 2 +- renovate.json5 | 2 ++ 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.github/workflows/storybook.yml b/.github/workflows/storybook.yml index e17ce2a889..037e6dd7f1 100644 --- a/.github/workflows/storybook.yml +++ b/.github/workflows/storybook.yml @@ -15,11 +15,7 @@ on: jobs: build: # Chromatic is not likely to be available for fork repositories, so we disable for fork repositories. - # Neither Dependabot nor Renovate will change the actual behavior for components. - if: >- - github.repository == 'misskey-dev/misskey' && - startsWith(github.head_ref, 'refs/heads/dependabot/') != true && - startsWith(github.head_ref, 'refs/heads/renovate/') != true + if: github.repository == 'misskey-dev/misskey' runs-on: ubuntu-latest env: diff --git a/packages/frontend/.storybook/changes.ts b/packages/frontend/.storybook/changes.ts index 1299910499..c7e0048818 100644 --- a/packages/frontend/.storybook/changes.ts +++ b/packages/frontend/.storybook/changes.ts @@ -55,7 +55,7 @@ await fs.readFile( '../../locales/ja-JP.yml', 'assets/**', 'public/**', - '../../pnpm-lock.yaml', + 'package.json', ]).length ) { return; diff --git a/renovate.json5 b/renovate.json5 index 395405972d..d2a491a7b4 100644 --- a/renovate.json5 +++ b/renovate.json5 @@ -38,6 +38,8 @@ 'packages/misskey-reversi/**/package.json', 'packages/sw/**/package.json', ], + // prevent wastage of Chromatic snapshots + rebaseWhen: 'never', }, { groupName: '[misskey-js] Update dependencies',