From ac51a969d184caeb3edd3ceaf25b182b0be0d8c3 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 19 Aug 2025 23:55:30 +0000 Subject: [PATCH] fix: prevent reaction count duplication by avoiding in-place array modification Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com> --- packages/frontend-embed/src/components/EmReactionsViewer.vue | 3 +-- packages/frontend/src/components/MkReactionsViewer.vue | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/frontend-embed/src/components/EmReactionsViewer.vue b/packages/frontend-embed/src/components/EmReactionsViewer.vue index f5aa6bdc3f..583748abfa 100644 --- a/packages/frontend-embed/src/components/EmReactionsViewer.vue +++ b/packages/frontend-embed/src/components/EmReactionsViewer.vue @@ -43,8 +43,7 @@ watch([() => props.note.reactions, () => props.maxNumber], ([newSource, maxNumbe for (let i = 0; i < reactions.value.length; i++) { const reaction = reactions.value[i][0]; if (reaction in newSource && newSource[reaction] !== 0) { - reactions.value[i][1] = newSource[reaction]; - newReactions.push(reactions.value[i]); + newReactions.push([reaction, newSource[reaction]]); } } diff --git a/packages/frontend/src/components/MkReactionsViewer.vue b/packages/frontend/src/components/MkReactionsViewer.vue index bd9ef50157..08a68a9564 100644 --- a/packages/frontend/src/components/MkReactionsViewer.vue +++ b/packages/frontend/src/components/MkReactionsViewer.vue @@ -86,8 +86,7 @@ watch([() => props.reactions, () => props.maxNumber], ([newSource, maxNumber]) = for (let i = 0; i < _reactions.value.length; i++) { const reaction = _reactions.value[i][0]; if (reaction in newSource && newSource[reaction] !== 0) { - _reactions.value[i][1] = newSource[reaction]; - newReactions.push(_reactions.value[i]); + newReactions.push([reaction, newSource[reaction]]); } }