From 997243915c8e1f8472da64f607f88c36cb1d5cb4 Mon Sep 17 00:00:00 2001 From: tamaina Date: Wed, 11 Jan 2023 15:59:43 +0000 Subject: [PATCH] =?UTF-8?q?apResolver=E3=81=AEUndiciFetcher=E3=82=92?= =?UTF-8?q?=E5=BB=83=E6=AD=A2=E3=81=97apRequest=E3=81=AE=E3=82=82=E3=81=AE?= =?UTF-8?q?=E3=82=92=E4=BD=BF=E3=81=86=E3=80=81=20add=20ap=20logger?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/backend/src/core/activitypub/ApRequestService.ts | 6 ++++-- .../backend/src/core/activitypub/ApResolverService.ts | 8 +------- 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/packages/backend/src/core/activitypub/ApRequestService.ts b/packages/backend/src/core/activitypub/ApRequestService.ts index c686a7bfd8..4a898956ea 100644 --- a/packages/backend/src/core/activitypub/ApRequestService.ts +++ b/packages/backend/src/core/activitypub/ApRequestService.ts @@ -6,6 +6,7 @@ import type { Config } from '@/config.js'; import type { User } from '@/models/entities/User.js'; import { UserKeypairStoreService } from '@/core/UserKeypairStoreService.js'; import { HttpRequestService, UndiciFetcher } from '@/core/HttpRequestService.js'; +import { LoggerService } from '@/core/LoggerService.js'; import { bindThis } from '@/decorators.js'; type Request = { @@ -28,7 +29,7 @@ type PrivateKey = { @Injectable() export class ApRequestService { - private undiciFetcher: UndiciFetcher; + public undiciFetcher: UndiciFetcher; constructor( @Inject(DI.config) @@ -36,10 +37,11 @@ export class ApRequestService { private userKeypairStoreService: UserKeypairStoreService, private httpRequestService: HttpRequestService, + private loggerService: LoggerService, ) { this.undiciFetcher = new UndiciFetcher(this.httpRequestService.getStandardUndiciFetcherOption({ maxRedirections: 0, - })); + }), this.loggerService.getLogger('ap-request')); } @bindThis diff --git a/packages/backend/src/core/activitypub/ApResolverService.ts b/packages/backend/src/core/activitypub/ApResolverService.ts index 2f8c97d375..d87a3d3605 100644 --- a/packages/backend/src/core/activitypub/ApResolverService.ts +++ b/packages/backend/src/core/activitypub/ApResolverService.ts @@ -4,7 +4,6 @@ import { InstanceActorService } from '@/core/InstanceActorService.js'; import type { NotesRepository, PollsRepository, NoteReactionsRepository, UsersRepository } from '@/models/index.js'; import type { Config } from '@/config.js'; import { MetaService } from '@/core/MetaService.js'; -import { HttpRequestService, UndiciFetcher } from '@/core/HttpRequestService.js'; import { DI } from '@/di-symbols.js'; import { UtilityService } from '@/core/UtilityService.js'; import { bindThis } from '@/decorators.js'; @@ -17,7 +16,6 @@ import type { IObject, ICollection, IOrderedCollection } from './type.js'; export class Resolver { private history: Set; private user?: ILocalUser; - private undiciFetcher: UndiciFetcher; constructor( private config: Config, @@ -29,15 +27,11 @@ export class Resolver { private instanceActorService: InstanceActorService, private metaService: MetaService, private apRequestService: ApRequestService, - private httpRequestService: HttpRequestService, private apRendererService: ApRendererService, private apDbResolverService: ApDbResolverService, private recursionLimit = 100, ) { this.history = new Set(); - this.undiciFetcher = new UndiciFetcher(this.httpRequestService.getStandardUndiciFetcherOption({ - maxRedirections: 0, - })); } @bindThis @@ -101,7 +95,7 @@ export class Resolver { const object = (this.user ? await this.apRequestService.signedGet(value, this.user) as IObject - : await this.undiciFetcher.getJson(value, 'application/activity+json, application/ld+json')); + : await this.apRequestService.undiciFetcher.getJson(value, 'application/activity+json, application/ld+json')); if (object == null || ( Array.isArray(object['@context']) ?