From 7149961f336130afd605e6a8085c57932c01a700 Mon Sep 17 00:00:00 2001 From: mattyatea Date: Thu, 19 Oct 2023 21:22:47 +0900 Subject: [PATCH] fix: iroiro MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: mattyatea カスタム絵文字一覧を一覧、新着、申請中に分離 (cherry picked from commit 5c464cd1bc177f0276397a686160c5c77e774d10) fix: 絵文字管理画面の表示不具合の修正 (cherry picked from commit 5300ff763bb008699b35dc6e219b50ac1c4fd7af) Signed-off-by: mattyatea Fix:draftが2重に宣言されてた Signed-off-by: mattyatea --- locales/index.d.ts | 5 + locales/ja-JP.yml | 5 + package.json | 2 +- .../api/endpoints/admin/emoji/add-draft.ts | 10 +- .../server/api/endpoints/admin/emoji/add.ts | 2 +- .../src/components/MkCustomEmojiEditDraft.vue | 214 ++++++++ .../src/components/MkCustomEmojiEditLocal.vue | 225 ++++++++ .../components/MkCustomEmojiEditRemote.vue | 110 ++++ .../MkEmojiEditDialog.vue} | 100 ++-- packages/frontend/src/pages/about.emojis.vue | 99 ++-- packages/frontend/src/pages/about.vue | 4 +- .../frontend/src/pages/admin/roles.editor.vue | 2 +- .../src/pages/custom-emojis-manager.vue | 490 ++++-------------- 13 files changed, 775 insertions(+), 493 deletions(-) create mode 100644 packages/frontend/src/components/MkCustomEmojiEditDraft.vue create mode 100644 packages/frontend/src/components/MkCustomEmojiEditLocal.vue create mode 100644 packages/frontend/src/components/MkCustomEmojiEditRemote.vue rename packages/frontend/src/{pages/emoji-edit-dialog.vue => components/MkEmojiEditDialog.vue} (79%) diff --git a/locales/index.d.ts b/locales/index.d.ts index 504df64250..1ebf723bed 100644 --- a/locales/index.d.ts +++ b/locales/index.d.ts @@ -824,6 +824,7 @@ export interface Locale { "high": string; "middle": string; "low": string; + "list": string; "emailNotConfiguredWarning": string; "ratio": string; "previewNoteText": string; @@ -1022,6 +1023,10 @@ export interface Locale { "notesSearchNotAvailable": string; "license": string; "draft": string; + "newEmojis": string; + "undrafted": string; + "draftEmojis": string; + "emojiNameValidation": string; "unfavoriteConfirm": string; "myClips": string; "drivecleaner": string; diff --git a/locales/ja-JP.yml b/locales/ja-JP.yml index db2420c40d..5efc26f1f3 100644 --- a/locales/ja-JP.yml +++ b/locales/ja-JP.yml @@ -821,6 +821,7 @@ priority: "優先度" high: "高" middle: "中" low: "低" +list: "一覧" emailNotConfiguredWarning: "メールアドレスの設定がされていません。" ratio: "比率" previewNoteText: "本文をプレビュー" @@ -1019,6 +1020,10 @@ sensitiveWordsDescription2: "スペースで区切るとAND指定になり、キ notesSearchNotAvailable: "ノート検索は利用できません。" license: "ライセンス" draft: "ドラフト" +newEmojis: "新着の絵文字" +undrafted: "ドラフト解除" +draftEmojis: "ドラフトされてる絵文字" +emojiNameValidation: "名前には英数字と_が利用できます。" unfavoriteConfirm: "お気に入り解除しますか?" myClips: "自分のクリップ" drivecleaner: "ドライブクリーナー" diff --git a/package.json b/package.json index a9b2b13532..9ebea7dc52 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "misskey", - "version": "2023.10.1", + "version": "2023.10.123", "codename": "nasubi", "repository": { "type": "git", diff --git a/packages/backend/src/server/api/endpoints/admin/emoji/add-draft.ts b/packages/backend/src/server/api/endpoints/admin/emoji/add-draft.ts index ac5082091e..57de1e0ed8 100644 --- a/packages/backend/src/server/api/endpoints/admin/emoji/add-draft.ts +++ b/packages/backend/src/server/api/endpoints/admin/emoji/add-draft.ts @@ -35,6 +35,8 @@ export const paramDef = { type: 'string', } }, license: { type: 'string', nullable: true }, + isSensitive: { type: 'boolean', nullable: true }, + localOnly: { type: 'boolean', nullable: true }, fileId: { type: 'string', format: 'misskey:id' }, }, required: ['name', 'fileId'], @@ -42,8 +44,8 @@ export const paramDef = { // TODO: ロジックをサービスに切り出す -// eslint-disable-next-line import/no-default-export @Injectable() +// eslint-disable-next-line import/no-default-export export default class extends Endpoint { constructor( @Inject(DI.driveFilesRepository) @@ -64,12 +66,16 @@ export default class extends Endpoint { category: ps.category ?? null, aliases: ps.aliases ?? [], license: ps.license ?? null, + isSensitive: ps.isSensitive ?? false, + localOnly: ps.localOnly ?? false, host: null, draft: true, + roleIdsThatCanBeUsedThisEmojiAsReaction: [], }); - this.moderationLogService.insertModerationLog(me, 'addEmoji', { + await this.moderationLogService.log(me, 'addCustomEmoji', { emojiId: emoji.id, + emoji: emoji, }); return { diff --git a/packages/backend/src/server/api/endpoints/admin/emoji/add.ts b/packages/backend/src/server/api/endpoints/admin/emoji/add.ts index 5e1b0e345c..251abbc8d0 100644 --- a/packages/backend/src/server/api/endpoints/admin/emoji/add.ts +++ b/packages/backend/src/server/api/endpoints/admin/emoji/add.ts @@ -51,7 +51,7 @@ export const paramDef = { type: 'string', } }, }, - required: ['name','fileId', 'draft'], + required: ['name', 'fileId', 'draft'], } as const; // TODO: ロジックをサービスに切り出す diff --git a/packages/frontend/src/components/MkCustomEmojiEditDraft.vue b/packages/frontend/src/components/MkCustomEmojiEditDraft.vue new file mode 100644 index 0000000000..c609898b66 --- /dev/null +++ b/packages/frontend/src/components/MkCustomEmojiEditDraft.vue @@ -0,0 +1,214 @@ + + + + + diff --git a/packages/frontend/src/components/MkCustomEmojiEditLocal.vue b/packages/frontend/src/components/MkCustomEmojiEditLocal.vue new file mode 100644 index 0000000000..7112a38430 --- /dev/null +++ b/packages/frontend/src/components/MkCustomEmojiEditLocal.vue @@ -0,0 +1,225 @@ + + + + + diff --git a/packages/frontend/src/components/MkCustomEmojiEditRemote.vue b/packages/frontend/src/components/MkCustomEmojiEditRemote.vue new file mode 100644 index 0000000000..26c8dd66ac --- /dev/null +++ b/packages/frontend/src/components/MkCustomEmojiEditRemote.vue @@ -0,0 +1,110 @@ + + + + + diff --git a/packages/frontend/src/pages/emoji-edit-dialog.vue b/packages/frontend/src/components/MkEmojiEditDialog.vue similarity index 79% rename from packages/frontend/src/pages/emoji-edit-dialog.vue rename to packages/frontend/src/components/MkEmojiEditDialog.vue index f830f09473..83c7fa4d22 100644 --- a/packages/frontend/src/pages/emoji-edit-dialog.vue +++ b/packages/frontend/src/components/MkEmojiEditDialog.vue @@ -7,11 +7,12 @@ SPDX-License-Identifier: AGPL-3.0-only +
@@ -34,6 +35,7 @@ SPDX-License-Identifier: AGPL-3.0-only {{ i18n.ts.selectFile }} + @@ -45,7 +47,7 @@ SPDX-License-Identifier: AGPL-3.0-only - + @@ -64,15 +66,17 @@ SPDX-License-Identifier: AGPL-3.0-only isSensitive {{ i18n.ts.localOnly }} - {{ i18n.ts.delete }} + + {{ i18n.ts.draft }} +
- {{ props.emoji ? i18n.ts.update : i18n.ts.create }} - - {{ i18n.ts.draft }} - - {{ i18n.ts.delete }} +
+ {{ i18n.ts.delete }} + {{ props.emoji ? i18n.ts.update : i18n.ts.create }} + {{ props.emoji ? i18n.ts.update : i18n.ts.create }} +
@@ -81,6 +85,7 @@ SPDX-License-Identifier: AGPL-3.0-only