diff --git a/.circleci/config.yml b/.circleci/config.yml index f26cadb5ac..05e6dde6ac 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -56,22 +56,10 @@ jobs: executor: type: string default: "default" - without_redis: - type: boolean - default: false executor: <> steps: - attach_workspace: at: /tmp/workspace - - when: - condition: <> - steps: - - run: - name: Configure - command: | - mv .config/test.yml .config/test_redis.yml - touch .config/test.yml - cat .config/test_redis.yml | while IFS= read line; do if [[ "$line" = '# __REDIS__' ]]; then break; else echo "$line" >> .config/test.yml; fi; done - run: name: Test command: | @@ -134,32 +122,14 @@ workflows: branches: only: master - test: - name: manual-test-with-redis - executor: with-redis + name: manual-test requires: - manual-build filters: branches: ignore: master - test: - name: auto-test-without-redis - executor: with-redis - requires: - - auto-build - filters: - branches: - only: master - - test: - name: manual-test-with-redis - without_redis: true - requires: - - manual-build - filters: - branches: - ignore: master - - test: - name: auto-test-without-redis - without_redis: true + name: auto-test requires: - auto-build filters: diff --git a/CHANGELOG.md b/CHANGELOG.md index 3e225b8aa6..f1c9ac460c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,13 @@ If you encounter any problems with updating, please try the following: 1. `npm run clean` or `npm run cleanall` 2. Retry update (Don't forget `npm i`) +11.1.5 (2019/04/17) +------------------- +### Fixes +* ユーザー名に含まれているカスタム絵文字が表示されないことがある問題を修正 +* 壁紙の設定ができない問題を修正 +* デザインの調整 + 11.1.4 (2019/04/17) ------------------- ### Fixes diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6825225e0e..edc6244d39 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -46,10 +46,40 @@ Convert な(na) to にゃ(nya) Revert Nyaize ## Code style -### Use semicolon -To avoid ASI Hazard +### セミコロンを省略しない +ASI Hazardを避けるためでもある + +### 中括弧を省略しない +Bad: +``` ts +if (foo) + bar; +else + baz; +``` + +Good: +``` ts +if (foo) { + bar; +} else { + baz; +} +``` + +ただし**`if`が一行**の時だけは省略しても良い +Good: +``` ts +if (foo) bar; +``` + +### `export default`を使わない +インテリセンスと相性が悪かったりするため + +参考: +* https://gfx.hatenablog.com/entry/2017/11/24/135343 +* https://basarat.gitbooks.io/typescript/docs/tips/defaultIsBad.html -### Don't use `export default` Bad: ``` ts export default function(foo: string): string { diff --git a/package.json b/package.json index c835c851f3..4135d3e588 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "misskey", "author": "syuilo ", - "version": "11.1.4", + "version": "11.1.5", "codename": "daybreak", "repository": { "type": "git", diff --git a/src/client/app/common/scripts/note-subscriber.ts b/src/client/app/common/scripts/note-subscriber.ts index 02d810ded9..d881fe01ce 100644 --- a/src/client/app/common/scripts/note-subscriber.ts +++ b/src/client/app/common/scripts/note-subscriber.ts @@ -137,7 +137,6 @@ export default prop => ({ Vue.set(this.$_ns_target, 'deletedAt', body.deletedAt); Vue.set(this.$_ns_target, 'renote', null); this.$_ns_target.text = null; - this.$_ns_target.tags = []; this.$_ns_target.fileIds = []; this.$_ns_target.poll = null; this.$_ns_target.geo = null; diff --git a/src/client/app/common/views/components/drive-file-thumbnail.vue b/src/client/app/common/views/components/drive-file-thumbnail.vue index 1a3ef37193..d6b0092ca2 100644 --- a/src/client/app/common/views/components/drive-file-thumbnail.vue +++ b/src/client/app/common/views/components/drive-file-thumbnail.vue @@ -121,7 +121,7 @@ export default Vue.extend({ if (this.file.properties.avgColor) { anime({ targets: this.$refs.thumbnail, - backgroundColor: this.file.properties.avgColor.replace('255)', '0)'), + backgroundColor: 'transparent', // TODO fade duration: 100, easing: 'linear' }); diff --git a/src/client/app/common/views/components/post-form-attaches.vue b/src/client/app/common/views/components/post-form-attaches.vue index 1fe476be77..37422ba108 100644 --- a/src/client/app/common/views/components/post-form-attaches.vue +++ b/src/client/app/common/views/components/post-form-attaches.vue @@ -32,7 +32,7 @@ export default Vue.extend({ props: { files: { - type: Object, + type: Array, required: true }, detachMediaFn: { diff --git a/src/client/app/common/views/components/settings/settings.vue b/src/client/app/common/views/components/settings/settings.vue index 001b692551..be2d7fce85 100644 --- a/src/client/app/common/views/components/settings/settings.vue +++ b/src/client/app/common/views/components/settings/settings.vue @@ -525,15 +525,11 @@ export default Vue.extend({ this.$chooseDriveFile({ multiple: false }).then(file => { - this.$root.api('i/update', { - wallpaperId: file.id - }); + this.$store.dispatch('settings/set', { key: 'wallpaper', value: file.url }); }); }, deleteWallpaper() { - this.$root.api('i/update', { - wallpaperId: null - }); + this.$store.dispatch('settings/set', { key: 'wallpaper', value: null }); }, checkForUpdate() { this.checkingForUpdate = true; diff --git a/src/client/app/common/views/widgets/post-form.vue b/src/client/app/common/views/widgets/post-form.vue index 120de0f17b..d8617bea58 100644 --- a/src/client/app/common/views/widgets/post-form.vue +++ b/src/client/app/common/views/widgets/post-form.vue @@ -21,7 +21,7 @@ - +