refactor: Refactor NoteReadService.read (#13429)

* refactor: Refactor NoteReadService.read

* clean up

* Update packages/backend/src/core/NoteReadService.ts

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>

packages/backend/src/core/NoteReadService.ts

@@ -88,22 +88,24 @@ export class NoteReadService implements OnApplicationShutdown {
 		userId: MiUser['id'],
 		notes: (MiNote | Packed<'Note'>)[],
 	): Promise<void> {
-		const readMentions: (MiNote | Packed<'Note'>)[] = [];
-		const readSpecifiedNotes: (MiNote | Packed<'Note'>)[] = [];
+		if (notes.length === 0) return;
+
+		const noteIds = new Set<MiNote['id']>();
 
 		for (const note of notes) {
 			if (note.mentions && note.mentions.includes(userId)) {
-				readMentions.push(note);
+				noteIds.add(note.id);
 			} else if (note.visibleUserIds && note.visibleUserIds.includes(userId)) {
-				readSpecifiedNotes.push(note);
+				noteIds.add(note.id);
 			}
 		}
 
-		if ((readMentions.length > 0) || (readSpecifiedNotes.length > 0)) {
+		if (noteIds.size === 0) return;
+
 		// Remove the record
 		await this.noteUnreadsRepository.delete({
 			userId: userId,
-				noteId: In([...readMentions.map(n => n.id), ...readSpecifiedNotes.map(n => n.id)]),
+			noteId: In(Array.from(noteIds)),
 		});
 
 		// TODO: ↓まとめてクエリしたい
@@ -128,7 +130,6 @@ export class NoteReadService implements OnApplicationShutdown {
 			}
 		}));
 	}
-	}
 
 	@bindThis
 	public dispose(): void {

packages/backend/src/server/api/endpoints/antennas/notes.ts

@@ -124,9 +124,7 @@ export default class extends Endpoint<typeof meta, typeof paramDef> { // eslint-
 				notes.sort((a, b) => a.id > b.id ? -1 : 1);
 			}
 
-			if (notes.length > 0) {
 			this.noteReadService.read(me.id, notes);
-			}
 
 			return await this.noteEntityService.packMany(notes, me);
 		});