usbharu
/
misskey
mirror of https://github.com/misskey-dev/misskey.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

clarify the reason behind dns lookup

This commit is contained in:
Kagami Sascha Rosylight 2023-07-01 15:44:03 +02:00
parent a08a40a1a8
commit 471ab88b42
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/backend/src/server/oauth/OAuth2ProviderService.ts
View File

@ -49,7 +49,6 @@ function validateClientId(raw: string): URL {
// https://datatracker.ietf.org/doc/html/rfc6749.html#section-3.1.2.1 // https://datatracker.ietf.org/doc/html/rfc6749.html#section-3.1.2.1
// 'The redirection endpoint SHOULD require the use of TLS as described // 'The redirection endpoint SHOULD require the use of TLS as described
// in Section 1.6 when the requested response type is "code" or "token"' // in Section 1.6 when the requested response type is "code" or "token"'
// TODO: Consider allowing custom URIs per RFC 8252.
const allowedProtocols = process.env.NODE_ENV === 'test' ? ['http:', 'https:'] : ['https:']; const allowedProtocols = process.env.NODE_ENV === 'test' ? ['http:', 'https:'] : ['https:'];
if (!allowedProtocols.includes(url.protocol)) { if (!allowedProtocols.includes(url.protocol)) {
throw new AuthorizationError('client_id must be a valid HTTPS URL', 'invalid_request'); throw new AuthorizationError('client_id must be a valid HTTPS URL', 'invalid_request');
@ -402,9 +401,10 @@ export class OAuth2ProviderService {
const clientUrl = validateClientId(clientID); const clientUrl = validateClientId(clientID);
// TODO: Consider allowing localhost for native apps (RFC 8252) // https://indieauth.spec.indieweb.org/#client-information-discovery
// This is currently blocked by the redirect_uri check below, but we can theoretically // "the server may want to resolve the domain name first and avoid fetching the document
// loosen the rule for localhost as the data never leaves the client machine. // if the IP address is within the loopback range defined by [RFC5735]
// or any other implementation-specific internal IP address."
if (process.env.NODE_ENV !== 'test' || process.env.MISSKEY_TEST_CHECK_IP_RANGE === '1') { if (process.env.NODE_ENV !== 'test' || process.env.MISSKEY_TEST_CHECK_IP_RANGE === '1') {
const lookup = await dns.lookup(clientUrl.hostname); const lookup = await dns.lookup(clientUrl.hostname);
if (ipaddr.parse(lookup.address).range() !== 'unicast') { if (ipaddr.parse(lookup.address).range() !== 'unicast') {