usbharu
/
misskey
mirror of https://github.com/misskey-dev/misskey.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

refactor: check if there is rate limit inside min/max function

This commit is contained in:
anatawa12 2024-06-14 17:41:39 +09:00
parent f72c768407
commit 3eb1875804
No known key found for this signature in database
GPG Key ID: 9CA909848B8E4EA6
1 changed files with 30 additions and 40 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
packages/backend/src/server/api/RateLimiterService.ts
View File

@ -50,53 +50,43 @@ export class RateLimiterService {
// Short-term limit // Short-term limit
const min = async () => { const min = async () => {
if (limitation.minInterval != null) {
const info = await this.checkLimiter({ const info = await this.checkLimiter({
id: `${actor}:${limitation.key}:min`, id: `${actor}:${limitation.key}:min`,
duration: limitation.minInterval! * factor, duration: limitation.minInterval * factor,
max: 1, max: 1,
db: this.redisClient, db: this.redisClient,
}); });
this.logger.debug(`${actor} ${limitation.key} min remaining: ${info.remaining}`); this.logger.debug(`${actor} ${limitation.key} min remaining: ${info.remaining}`);
if (info.remaining === 0) { if (info.remaining === 0) {
// eslint-disable-next-line no-throw-literal // eslint-disable-next-line no-throw-literal
throw { code: 'BRIEF_REQUEST_INTERVAL', info }; throw { code: 'BRIEF_REQUEST_INTERVAL', info };
} else { } else {
return; return;
} }
}
}; };
// Long term limit // Long term limit
const max = async () => { const max = async () => {
if (limitation.duration != null && limitation.max != null) {
const info = await this.checkLimiter({ const info = await this.checkLimiter({
id: `${actor}:${limitation.key}`, id: `${actor}:${limitation.key}`,
duration: limitation.duration! * factor, duration: limitation.duration * factor,
max: limitation.max! / factor, max: limitation.max / factor,
db: this.redisClient, db: this.redisClient,
}); });
this.logger.debug(`${actor} ${limitation.key} max remaining: ${info.remaining}`); this.logger.debug(`${actor} ${limitation.key} max remaining: ${info.remaining}`);
if (info.remaining === 0) { if (info.remaining === 0) {
// eslint-disable-next-line no-throw-literal // eslint-disable-next-line no-throw-literal
throw { code: 'RATE_LIMIT_EXCEEDED', info }; throw { code: 'RATE_LIMIT_EXCEEDED', info };
} else { } else {
return; return;
} }
}
}; };
const hasShortTermLimit = typeof limitation.minInterval === 'number';
const hasLongTermLimit =
typeof limitation.duration === 'number' &&
typeof limitation.max === 'number';
if (hasShortTermLimit) {
await min(); await min();
}
if (hasLongTermLimit) {
await max(); await max();
} }
} }
}