From 01cb14f78dcb22904ece0561759bf8e1bbe15f9a Mon Sep 17 00:00:00 2001 From: Kisaragi <48310258+KisaragiEffective@users.noreply.github.com> Date: Thu, 6 Mar 2025 19:41:30 +0900 Subject: [PATCH 1/3] refactor: avoid any --- packages/backend/src/misc/is-reply.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/backend/src/misc/is-reply.ts b/packages/backend/src/misc/is-reply.ts index 980eae11c9..b97787bb6e 100644 --- a/packages/backend/src/misc/is-reply.ts +++ b/packages/backend/src/misc/is-reply.ts @@ -4,7 +4,8 @@ */ import { MiUser } from '@/models/User.js'; +import { MiNote } from '@/models/Note.js'; -export function isReply(note: any, viewerId?: MiUser['id'] | undefined | null): boolean { +export function isReply(note: Note, viewerId?: MiUser['id'] | undefined | null): boolean { return note.replyId && note.replyUserId !== note.userId && note.replyUserId !== viewerId; } From b8fde212ad4a5c69a33c5eb3f3c5450e2fc8159f Mon Sep 17 00:00:00 2001 From: Kisaragi <48310258+KisaragiEffective@users.noreply.github.com> Date: Thu, 6 Mar 2025 19:56:27 +0900 Subject: [PATCH 2/3] Update is-reply.ts --- packages/backend/src/misc/is-reply.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/backend/src/misc/is-reply.ts b/packages/backend/src/misc/is-reply.ts index b97787bb6e..7114a3e0ff 100644 --- a/packages/backend/src/misc/is-reply.ts +++ b/packages/backend/src/misc/is-reply.ts @@ -6,6 +6,6 @@ import { MiUser } from '@/models/User.js'; import { MiNote } from '@/models/Note.js'; -export function isReply(note: Note, viewerId?: MiUser['id'] | undefined | null): boolean { +export function isReply(note: MiNote, viewerId?: MiUser['id'] | undefined | null): boolean { return note.replyId && note.replyUserId !== note.userId && note.replyUserId !== viewerId; } From ea9c3239e59da303dc226e86086a2df602e488ab Mon Sep 17 00:00:00 2001 From: Kisaragi <48310258+KisaragiEffective@users.noreply.github.com> Date: Thu, 6 Mar 2025 20:59:36 +0900 Subject: [PATCH 3/3] fix nullability --- packages/backend/src/misc/is-reply.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/backend/src/misc/is-reply.ts b/packages/backend/src/misc/is-reply.ts index 7114a3e0ff..5b5bbbc373 100644 --- a/packages/backend/src/misc/is-reply.ts +++ b/packages/backend/src/misc/is-reply.ts @@ -7,5 +7,5 @@ import { MiUser } from '@/models/User.js'; import { MiNote } from '@/models/Note.js'; export function isReply(note: MiNote, viewerId?: MiUser['id'] | undefined | null): boolean { - return note.replyId && note.replyUserId !== note.userId && note.replyUserId !== viewerId; + return note.replyId !== undefined && note.replyUserId !== note.userId && note.replyUserId !== viewerId; }