refactor: Extract well-known services

src/client/components/mention.vue

@@ -18,6 +18,7 @@
 import Vue from 'vue';
 import { toUnicode } from 'punycode';
 import { host as localHost } from '../config';
+import { wellKnownServices } from '../../well-known-services';
 
 export default Vue.extend({
 	props: {
@@ -37,11 +38,10 @@ export default Vue.extend({
 	},
 	computed: {
 		url(): string {
-			switch (this.host) {
+			const wellKnown = wellKnownServices.find(x => x[0] === this.host);
-				case 'twitter.com':
+			if (wellKnown) {
-				case 'github.com':
+				return wellKnown[1](this.username);
-					return `https://${this.host}/${this.username}`;
+			} else {
-				default:
 				return `/${this.canonical}`;
 			}
 		},

src/mfm/to-html.ts

@@ -3,6 +3,7 @@ import config from '../config';
 import { intersperse } from '../prelude/array';
 import { MfmForest, MfmTree } from './prelude';
 import { IMentionedRemoteUsers } from '../models/entities/note';
+import { wellKnownServices } from '../well-known-services';
 
 export function toHtml(tokens: MfmForest | null, mentionedRemoteUsers: IMentionedRemoteUsers = []) {
 	if (tokens == null) {
@@ -126,18 +127,13 @@ export function toHtml(tokens: MfmForest | null, mentionedRemoteUsers: IMentione
 		mention(token) {
 			const a = doc.createElement('a');
 			const { username, host, acct } = token.node.props;
-			switch (host) {
+			const wellKnown = wellKnownServices.find(x => x[0] === host);
-				case 'github.com':
+			if (wellKnown) {
-					a.href = `https://github.com/${username}`;
+				a.href = wellKnown[1](username);
-					break;
+			} else {
-				case 'twitter.com':
-					a.href = `https://twitter.com/${username}`;
-					break;
-				default:
 				const remoteUserInfo = mentionedRemoteUsers.find(remoteUser => remoteUser.username === username && remoteUser.host === host);
 				a.href = remoteUserInfo ? (remoteUserInfo.url ? remoteUserInfo.url : remoteUserInfo.uri) : `${config.url}/${acct}`;
 				a.className = 'u-url mention';
-					break;
 			}
 			a.textContent = acct;
 			return a;

src/well-known-services.ts

@@ -0,0 +1,4 @@
+export const wellKnownServices = [
+	['twitter.com', username => `https://twitter.com/${username}`],
+	['github.com', username => `https://github.com/${username}`],
+] as [string, (username: string) => string][];