usbharu/Hideout
1
0
Fork 0
mirror of https://github.com/usbharu/Hideout.git synced 2026-07-27 07:33:36 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor: SnowflakeIdGenerateServiceを改良

Browse Source
This commit is contained in:
usbharu
2024-08-24 11:31:36 +09:00
parent 4dcec9e806
commit c872a837eb
2 changed files with 15 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
hideout-core/src/main/kotlin/dev/usbharu/hideout/core/infrastructure/other/SnowflakeIdGenerateService.kt
+7 -6
View File
@@ -24,9 +24,9 @@ import java.time.Instant
@Suppress("MagicNumber") @Suppress("MagicNumber")
open class SnowflakeIdGenerateService(private val baseTime: Long) : IdGenerateService { open class SnowflakeIdGenerateService(private val baseTime: Long) : IdGenerateService {
var lastTimeStamp: Long = -1 private var lastTimeStamp: Long = -1
var sequenceId: Int = 0 private var sequenceId: Long = 0
val mutex = Mutex() private val mutex = Mutex()
@Throws(IllegalStateException::class) @Throws(IllegalStateException::class)
override suspend fun generateId(): Long { override suspend fun generateId(): Long {
@@ -34,7 +34,6 @@ open class SnowflakeIdGenerateService(private val baseTime: Long) : IdGenerateSe
var timestamp = getTime() var timestamp = getTime()
if (timestamp < lastTimeStamp) { if (timestamp < lastTimeStamp) {
timestamp = wait(timestamp) timestamp = wait(timestamp)
// throw IllegalStateException(" $lastTimeStamp $timestamp ${lastTimeStamp-timestamp} ")
} }
if (timestamp == lastTimeStamp) { if (timestamp == lastTimeStamp) {
sequenceId++ sequenceId++
@@ -46,7 +45,7 @@ open class SnowflakeIdGenerateService(private val baseTime: Long) : IdGenerateSe
sequenceId = 0 sequenceId = 0
} }
lastTimeStamp = timestamp lastTimeStamp = timestamp
return@withLock (timestamp - baseTime).shl(22).or(1L.shl(12)).or(sequenceId.toLong()) return@withLock (timestamp - baseTime).shl(22).or(1L.shl(12)).or(sequenceId)
} }
} }
@@ -77,8 +76,10 @@ open class SnowflakeIdGenerateService(private val baseTime: Long) : IdGenerateSe
override fun hashCode(): Int { override fun hashCode(): Int {
var result = baseTime.hashCode() var result = baseTime.hashCode()
result = 31 * result + lastTimeStamp.hashCode() result = 31 * result + lastTimeStamp.hashCode()
result = 31 * result + sequenceId result = 31 * result + sequenceId.hashCode()
result = 31 * result + mutex.hashCode() result = 31 * result + mutex.hashCode()
return result return result
} }
} }
hideout-core/src/test/kotlin/dev/usbharu/hideout/core/infrastructure/other/TwitterSnowflakeIdGenerateServiceTest.kt
+8 -14
View File
@@ -1,28 +1,22 @@
package dev.usbharu.hideout.core.infrastructure.other package dev.usbharu.hideout.core.infrastructure.other
import kotlinx.coroutines.Dispatchers import kotlinx.coroutines.async
import kotlinx.coroutines.awaitAll
import kotlinx.coroutines.coroutineScope import kotlinx.coroutines.coroutineScope
import kotlinx.coroutines.launch
import kotlinx.coroutines.runBlocking import kotlinx.coroutines.runBlocking
import kotlinx.coroutines.sync.Mutex
import kotlinx.coroutines.sync.withLock
import org.junit.jupiter.api.Assertions.assertEquals import org.junit.jupiter.api.Assertions.assertEquals
import org.junit.jupiter.api.Test import org.junit.jupiter.api.Test
class TwitterSnowflakeIdGenerateServiceTest { class TwitterSnowflakeIdGenerateServiceTest {
@Test @Test
fun noDuplicateTest() = runBlocking { fun noDuplicateTest() = runBlocking {
val mutex = Mutex()
val mutableListOf = mutableListOf<Long>() val mutableListOf = coroutineScope {
coroutineScope { (1..10000).map {
repeat(500000) { async {
launch(Dispatchers.IO) { TwitterSnowflakeIdGenerateService.generateId()
val id = TwitterSnowflakeIdGenerateService.generateId()
mutex.withLock {
mutableListOf.add(id)
}
}
} }
}.awaitAll()
} }
assertEquals(0, mutableListOf.size - mutableListOf.toSet().size) assertEquals(0, mutableListOf.size - mutableListOf.toSet().size)