mirror of https://github.com/usbharu/Hideout.git
Apply suggestions from code review
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This commit is contained in:
parent
e40e2c0d96
commit
c0dffe7c98
|
@ -29,7 +29,6 @@ class APReceiveFollowJobProcessor(
|
|||
val person = apUserService.fetchPerson(param.actor, param.targetActor)
|
||||
val follow = objectMapper.readValue<Follow>(param.follow)
|
||||
|
||||
|
||||
logger.info("START Follow from: {} to {}", param.targetActor, param.actor)
|
||||
|
||||
val signer = userQueryService.findByUrl(param.targetActor)
|
||||
|
|
|
@ -21,7 +21,6 @@ class ApRemoveReactionJobProcessor(
|
|||
private val applicationConfig: ApplicationConfig
|
||||
) : JobProcessor<DeliverRemoveReactionJobParam, DeliverRemoveReactionJob> {
|
||||
override suspend fun process(param: DeliverRemoveReactionJobParam): Unit = transaction.transaction {
|
||||
|
||||
val like = objectMapper.readValue<Like>(param.like)
|
||||
|
||||
val signer = userQueryService.findByUrl(param.actor)
|
||||
|
|
|
@ -30,5 +30,4 @@ abstract class AbstractActivityPubProcessor<T : Object>(
|
|||
}
|
||||
|
||||
abstract suspend fun internalProcess(activity: ActivityPubProcessContext<T>)
|
||||
|
||||
}
|
||||
|
|
|
@ -35,7 +35,6 @@ class InboxJobProcessor(
|
|||
private val transaction: Transaction
|
||||
) : JobProcessor<InboxJobParam, InboxJob> {
|
||||
suspend fun process(props: JobProps<InboxJob>) {
|
||||
|
||||
val type = ActivityType.valueOf(props[InboxJob.type])
|
||||
val jsonString = objectMapper.readTree(props[InboxJob.json])
|
||||
val httpRequestString = props[InboxJob.httpRequest]
|
||||
|
|
|
@ -29,7 +29,6 @@ object ReceiveFollowJob : HideoutJob<ReceiveFollowJobParam, ReceiveFollowJob>("R
|
|||
props[follow] = value.follow
|
||||
props[actor] = value.actor
|
||||
props[targetActor] = value.targetActor
|
||||
|
||||
}
|
||||
|
||||
override fun convert(props: JobProps<ReceiveFollowJob>): ReceiveFollowJobParam = ReceiveFollowJobParam(
|
||||
|
@ -78,7 +77,9 @@ object DeliverReactionJob : HideoutJob<DeliverReactionJobParam, DeliverReactionJ
|
|||
val actor: Prop<DeliverReactionJob, String> = string("actor")
|
||||
val inbox: Prop<DeliverReactionJob, String> = string("inbox")
|
||||
val id: Prop<DeliverReactionJob, String> = string("id")
|
||||
override fun convert(value: DeliverReactionJobParam): ScheduleContext<DeliverReactionJob>.(DeliverReactionJob) -> Unit =
|
||||
override fun convert(
|
||||
value: DeliverReactionJobParam
|
||||
): ScheduleContext<DeliverReactionJob>.(DeliverReactionJob) -> Unit =
|
||||
{
|
||||
props[reaction] = value.reaction
|
||||
props[postUrl] = value.postUrl
|
||||
|
|
|
@ -24,7 +24,10 @@ class KJobJobQueueWorkerService(private val jobQueueProcessorList: List<JobProce
|
|||
}.start()
|
||||
}
|
||||
|
||||
override fun <T, R : HideoutJob<T, R>> init(defines: List<Pair<R, JobRegisterContext<R, JobContextWithProps<R>>.(R) -> KJobFunctions<R, JobContextWithProps<R>>>>) {
|
||||
override fun <T, R : HideoutJob<T, R>> init(
|
||||
defines:
|
||||
List<Pair<R, JobRegisterContext<R, JobContextWithProps<R>>.(R) -> KJobFunctions<R, JobContextWithProps<R>>>>
|
||||
) {
|
||||
defines.forEach { job ->
|
||||
kjob.register(job.first, job.second)
|
||||
}
|
||||
|
|
|
@ -23,7 +23,8 @@ class KJobMongoJobQueueWorkerService(private val mongoClient: MongoClient) : Job
|
|||
}.start()
|
||||
}
|
||||
|
||||
override fun <T, R : HideoutJob<T, R>> init(defines: List<Pair<R, JobRegisterContext<R, JobContextWithProps<R>>.(R) -> KJobFunctions<R, JobContextWithProps<R>>>>) {
|
||||
override fun <T, R : HideoutJob<T, R>> init(defines:
|
||||
List<Pair<R, JobRegisterContext<R, JobContextWithProps<R>>.(R) -> KJobFunctions<R, JobContextWithProps<R>>>>) {
|
||||
defines.forEach { job ->
|
||||
kjob.register(job.first, job.second)
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue