From 56458fc53c6445b93aeda48513d669dd2d32bd25 Mon Sep 17 00:00:00 2001 From: usbharu <64310155+usbharu@users.noreply.github.com> Date: Thu, 30 Nov 2023 13:15:02 +0900 Subject: [PATCH] =?UTF-8?q?refactor:=20Spring=20Security=E3=81=AE=E3=82=B3?= =?UTF-8?q?=E3=83=B3=E3=83=95=E3=82=A3=E3=82=B0=E3=82=92Kotlin=20DSL?= =?UTF-8?q?=E3=81=A7=E8=A8=98=E8=BF=B0=E3=81=99=E3=82=8B=E3=82=88=E3=81=86?= =?UTF-8?q?=E3=81=AB?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../application/config/SecurityConfig.kt | 148 +++++++++--------- .../util/SpringSecurityKotlinDslExtension.kt | 13 ++ src/main/resources/application.yml | 2 +- 3 files changed, 84 insertions(+), 79 deletions(-) create mode 100644 src/main/kotlin/dev/usbharu/hideout/util/SpringSecurityKotlinDslExtension.kt diff --git a/src/main/kotlin/dev/usbharu/hideout/application/config/SecurityConfig.kt b/src/main/kotlin/dev/usbharu/hideout/application/config/SecurityConfig.kt index 837c1ea6..fb2e86ec 100644 --- a/src/main/kotlin/dev/usbharu/hideout/application/config/SecurityConfig.kt +++ b/src/main/kotlin/dev/usbharu/hideout/application/config/SecurityConfig.kt @@ -13,28 +13,29 @@ import dev.usbharu.hideout.core.infrastructure.springframework.httpsignature.Htt import dev.usbharu.hideout.core.infrastructure.springframework.oauth2.UserDetailsImpl import dev.usbharu.hideout.core.query.UserQueryService import dev.usbharu.hideout.util.RsaUtil +import dev.usbharu.hideout.util.hasAnyScope import dev.usbharu.httpsignature.sign.RsaSha256HttpSignatureSigner import dev.usbharu.httpsignature.verify.DefaultSignatureHeaderParser import dev.usbharu.httpsignature.verify.RsaSha256HttpSignatureVerifier import org.springframework.beans.factory.annotation.Autowired import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty import org.springframework.boot.autoconfigure.jackson.Jackson2ObjectMapperBuilderCustomizer -import org.springframework.boot.autoconfigure.security.servlet.PathRequest import org.springframework.boot.context.properties.ConfigurationProperties import org.springframework.context.annotation.Bean import org.springframework.context.annotation.Configuration import org.springframework.context.annotation.Primary import org.springframework.core.annotation.Order -import org.springframework.http.HttpMethod +import org.springframework.http.HttpMethod.GET +import org.springframework.http.HttpMethod.POST import org.springframework.http.HttpStatus import org.springframework.http.converter.json.Jackson2ObjectMapperBuilder import org.springframework.http.converter.json.MappingJackson2HttpMessageConverter import org.springframework.security.authentication.AccountStatusUserDetailsChecker import org.springframework.security.authentication.AuthenticationManager -import org.springframework.security.config.Customizer import org.springframework.security.config.annotation.authentication.configuration.AuthenticationConfiguration import org.springframework.security.config.annotation.web.builders.HttpSecurity import org.springframework.security.config.annotation.web.configuration.EnableWebSecurity +import org.springframework.security.config.annotation.web.invoke import org.springframework.security.config.http.SessionCreationPolicy import org.springframework.security.core.Authentication import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder @@ -51,15 +52,14 @@ import org.springframework.security.web.authentication.AuthenticationEntryPointF import org.springframework.security.web.authentication.HttpStatusEntryPoint import org.springframework.security.web.authentication.LoginUrlAuthenticationEntryPoint import org.springframework.security.web.authentication.preauth.PreAuthenticatedAuthenticationProvider -import org.springframework.security.web.servlet.util.matcher.MvcRequestMatcher +import org.springframework.security.web.savedrequest.RequestCacheAwareFilter import org.springframework.security.web.util.matcher.AnyRequestMatcher -import org.springframework.web.servlet.handler.HandlerMappingIntrospector import java.security.KeyPairGenerator import java.security.interfaces.RSAPrivateKey import java.security.interfaces.RSAPublicKey import java.util.* -@EnableWebSecurity(debug = false) +@EnableWebSecurity(debug = true) @Configuration @Suppress("FunctionMaxLength", "TooManyFunctions") class SecurityConfig { @@ -75,40 +75,26 @@ class SecurityConfig { @Order(1) fun httpSignatureFilterChain( http: HttpSecurity, - httpSignatureFilter: HttpSignatureFilter, - introspector: HandlerMappingIntrospector + httpSignatureFilter: HttpSignatureFilter ): SecurityFilterChain { - val builder = MvcRequestMatcher.Builder(introspector) - http - .securityMatcher("/users/*/posts/*") - .addFilter(httpSignatureFilter) - .addFilterBefore( - ExceptionTranslationFilter(HttpStatusEntryPoint(HttpStatus.UNAUTHORIZED)), - HttpSignatureFilter::class.java - ) - .authorizeHttpRequests { - it.requestMatchers( - builder.pattern("/inbox"), - builder.pattern("/outbox"), - builder.pattern("/users/*/inbox"), - builder.pattern("/users/*/outbox") - ).authenticated() - it.anyRequest().permitAll() + http { + securityMatcher("/users/*/posts/*") + addFilterAt(httpSignatureFilter) + addFilterBefore(ExceptionTranslationFilter(HttpStatusEntryPoint(HttpStatus.UNAUTHORIZED))) + authorizeHttpRequests { + authorize(anyRequest, permitAll) } - .csrf { - it.disable() - } - .exceptionHandling { - it.authenticationEntryPoint(HttpStatusEntryPoint(HttpStatus.UNAUTHORIZED)) - it.defaultAuthenticationEntryPointFor( + exceptionHandling { + authenticationEntryPoint = HttpStatusEntryPoint(HttpStatus.UNAUTHORIZED) + defaultAuthenticationEntryPointFor( HttpStatusEntryPoint(HttpStatus.UNAUTHORIZED), AnyRequestMatcher.INSTANCE ) } - .sessionManagement { - it.sessionCreationPolicy(SessionCreationPolicy.STATELESS) + sessionManagement { + sessionCreationPolicy = SessionCreationPolicy.STATELESS } - + } return http.build() } @@ -152,59 +138,65 @@ class SecurityConfig { @Bean @Order(2) - fun oauth2SecurityFilterChain(http: HttpSecurity, introspector: HandlerMappingIntrospector): SecurityFilterChain { - val builder = MvcRequestMatcher.Builder(introspector) - + fun oauth2SecurityFilterChain(http: HttpSecurity): SecurityFilterChain { OAuth2AuthorizationServerConfiguration.applyDefaultSecurity(http) - http.exceptionHandling { - it.authenticationEntryPoint( - LoginUrlAuthenticationEntryPoint("/login") - ) - }.oauth2ResourceServer { - it.jwt(Customizer.withDefaults()) + http { + exceptionHandling { + authenticationEntryPoint = LoginUrlAuthenticationEntryPoint("/login") + } + oauth2ResourceServer { + jwt { + + } + } } return http.build() } @Bean @Order(4) - fun defaultSecurityFilterChain(http: HttpSecurity, introspector: HandlerMappingIntrospector): SecurityFilterChain { - val builder = MvcRequestMatcher.Builder(introspector) + fun defaultSecurityFilterChain(http: HttpSecurity): SecurityFilterChain { + http { + authorizeHttpRequests { - http.authorizeHttpRequests { - it.requestMatchers(PathRequest.toH2Console()).permitAll() - it.requestMatchers( - builder.pattern("/inbox"), - builder.pattern("/users/*/inbox"), - builder.pattern("/api/v1/apps"), - builder.pattern("/api/v1/instance/**"), - builder.pattern("/.well-known/**"), - builder.pattern("/error"), - builder.pattern("/nodeinfo/2.0"), - builder.pattern("/api/v1/accounts") - ).permitAll() - it.requestMatchers( - builder.pattern("/auth/**") - ).anonymous() - it.requestMatchers(builder.pattern("/change-password")).authenticated() - it.requestMatchers(builder.pattern("/api/v1/accounts/verify_credentials")) - .hasAnyAuthority("SCOPE_read", "SCOPE_read:accounts") - it.requestMatchers(builder.pattern(HttpMethod.POST, "/api/v1/media")) - .hasAnyAuthority("SCOPE_write", "SCOPE_write:media") - it.requestMatchers(builder.pattern(HttpMethod.POST, "/api/v1/statuses")) - .hasAnyAuthority("SCOPE_write", "SCOPE_write:statuses") - it.anyRequest().authenticated() - } - http.oauth2ResourceServer { - it.jwt(Customizer.withDefaults()) - }.passwordManagement { }.formLogin(Customizer.withDefaults()).csrf { - it.ignoringRequestMatchers(builder.pattern("/users/*/inbox")) - it.ignoringRequestMatchers(builder.pattern(HttpMethod.POST, "/api/v1/apps")) - it.ignoringRequestMatchers(builder.pattern("/inbox")) - it.ignoringRequestMatchers(PathRequest.toH2Console()) - }.headers { - it.frameOptions { frameOptionsConfig -> - frameOptionsConfig.sameOrigin() + authorize("/error", permitAll) + authorize("/login", permitAll) + authorize(GET, "/.well-known/**", permitAll) + authorize(GET, "/nodeinfo/2.0", permitAll) + + authorize(POST, "/inbox", permitAll) + authorize(POST, "/users/*/inbox", permitAll) + + authorize(POST, "/api/v1/apps", permitAll) + authorize(GET, "/api/v1/instance/**", permitAll) + authorize(POST, "/api/v1/accounts", permitAll) + + authorize("/auth/sign_up", hasRole("ANONYMOUS")) + + authorize(GET, "/api/v1/accounts/verify_credentials", hasAnyScope("read", "read:accounts")) + + authorize(POST, "/api/v1/media", hasAnyScope("write", "write:media")) + authorize(POST, "/api/v1/statuses", hasAnyScope("write", "write:statuses")) + + authorize(anyRequest, authenticated) + } + + oauth2ResourceServer { + jwt { } + } + + formLogin { + + } + + csrf { + ignoringRequestMatchers("/users/*/inbox", "/inbox", "/api/v1/apps", "/api/v1/accounts") + } + + headers { + frameOptions { + sameOrigin = true + } } } return http.build() diff --git a/src/main/kotlin/dev/usbharu/hideout/util/SpringSecurityKotlinDslExtension.kt b/src/main/kotlin/dev/usbharu/hideout/util/SpringSecurityKotlinDslExtension.kt new file mode 100644 index 00000000..42159643 --- /dev/null +++ b/src/main/kotlin/dev/usbharu/hideout/util/SpringSecurityKotlinDslExtension.kt @@ -0,0 +1,13 @@ +package dev.usbharu.hideout.util + +import org.springframework.security.authorization.AuthorizationManager +import org.springframework.security.config.annotation.web.AuthorizeHttpRequestsDsl +import org.springframework.security.web.access.intercept.RequestAuthorizationContext + +fun AuthorizeHttpRequestsDsl.hasScope(scope: String): AuthorizationManager = + hasAuthority("SCOPE_$scope") + +fun AuthorizeHttpRequestsDsl.hasAnyScope(vararg scopes: String): AuthorizationManager = + hasAnyAuthority( + *scopes.map { "SCOPE_$it" }.toTypedArray() + ) diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml index daff34db..9565e8cd 100644 --- a/src/main/resources/application.yml +++ b/src/main/resources/application.yml @@ -36,7 +36,7 @@ spring: max-request-size: 40MB h2: console: - enabled: true + enabled: false server: tomcat: basedir: tomcat